Ошибка в сортировке

[mr.stranger]

В сортировке по числовому признаку, смотрит только на первую цифру, а не на все число
Помогите пожалуйста исправить

procedure TForm1.Button1Click(Sender: TObject);
 var a,b,c,f1,f2,f3,q1,q2,q3,q4:integer;
begin
q1 := 0;
q2 := 0;
q3 := 0;
q4 := 0;

for a := 1 to StringGrid1.RowCount-1 do
if StringGrid1.Cells[1,a] = Trim(Edit1.Text) then
q1 := 1;
for a := 1 to StringGrid1.RowCount-1 do
if StringGrid1.Cells[2,a] = Trim(Edit2.Text) then
q2 := 1;
for a := 1 to StringGrid1.RowCount-1 do
if StringGrid1.Cells[3,a] = Trim(Edit3.Text) then
q3 := 1;
q4 := q1 + q2 + q3;

Val(Trim(Edit1.Text),b,f1);
Val(Trim(Edit2.Text),b,f2);
Val(Trim(Edit3.Text),c,f3);

if (Length(Edit1.text) <> 0) and (Length(Edit2.text) <> 0) and (Length(Edit3.text) <> 0) and (f3 = 0) and (f1 <> 0) and (f2 <> 0) and (c > 0) then
begin
if q4 <> 3 then
begin
with StringGrid1 do
InsertRowWithValues(RowCount, [IntToStr(RowCount), Edit1.Text, Edit2.Text, Edit3.Text]);
end
else
ShowMessage('Дублированная запись');
end
else
ShowMessage('Ошибки в записи');
end;

procedure TForm1.Button2Click(Sender: TObject);
var
 ms1,ms2,ms3:array of string;
 s1,s2,s3:string;
 i,j:integer;
begin
SetLength(ms1,StringGrid1.RowCount);
SetLength(ms2,StringGrid1.RowCount);
SetLength(ms3,StringGrid1.RowCount);

if RadioButton1.Checked = True then
begin

for i := 1 to StringGrid1.RowCount-1 do
begin
ms1[i] := StringGrid1.Cells[1,i];
ms2[i] := StringGrid1.Cells[2,i];
ms3[i] := StringGrid1.Cells[3,i];
end;
for i := 1 to StringGrid1.RowCount-1 do
for j := 1 to StringGrid1.RowCount-i-1 do
begin
if ms1[j] > ms1[j+1] then
begin
s1 := ms1[j];
ms1[j] := ms1[j+1];
ms1[j+1] := s1;

s2 := ms2[j];
ms2[j] := ms2[j+1];
ms2[j+1] := s2;

s3 := ms3[j];
ms3[j] := ms3[j+1];
ms3[j+1] := s3;
end;
end;
for i := 1 to StringGrid1.RowCount-1 do
begin
StringGrid1.Cells[1,i] := ms1[i];
StringGrid1.Cells[2,i] := ms2[i];
StringGrid1.Cells[3,i] := ms3[i];
end;

end
else
if RadioButton2.Checked = True then
begin

for i := 1 to StringGrid1.RowCount-1 do
begin
ms1[i] := StringGrid1.Cells[1,i];
ms2[i] := StringGrid1.Cells[2,i];
ms3[i] := StringGrid1.Cells[3,i];
end;
for i := 1 to StringGrid1.RowCount-1 do
for j := 1 to StringGrid1.RowCount-i-1 do
begin
if ms3[j] > ms3[j+1] then
begin
s1 := ms1[j];
ms1[j] := ms1[j+1];
ms1[j+1] := s1;

s2 := ms2[j];
ms2[j] := ms2[j+1];
ms2[j+1] := s2;

s3 := ms3[j];
ms3[j] := ms3[j+1];
ms3[j+1] := s3;
end;
end;
for i := 1 to StringGrid1.RowCount-1 do
begin
StringGrid1.Cells[1,i] := ms1[i];
StringGrid1.Cells[2,i] := ms2[i];
StringGrid1.Cells[3,i] := ms3[i];
end;
end;
end;
end.

Ниже - форма ввода в стринггрид

[macomics]

Если год записан цифрами, то сравнивайте так

if strtoint(ms3[j]) > strtoint(ms3[j+1]) then

А еще лучше ms3 объявите числовым и преобразуйте при загрузке и выгрузке один раз.

[mr.stranger]

Сообщение от macomics

if strtoint(ms3[j]) > strtoint(ms3[j+1]) then

Помогло, спасибо

[Valick]

Сообщение от macomics

А еще лучше ms3 объявите числовым и преобразуйте при загрузке и выгрузке один раз.

а это видимо для Александра Сергеевича...

[macomics]

Пушкин писал на Русском. Паскаля тогда еще не придумали.

[mr.stranger]

Обновлено

procedure TForm1.Button2Click(Sender: TObject);
var
 ms1,ms2:array of string;
 ms3:array of integer;
 s1,s2,s3:string;
 i,j:integer;
begin
SetLength(ms1,StringGrid1.RowCount);
SetLength(ms2,StringGrid1.RowCount);
SetLength(ms3,StringGrid1.RowCount);

if RadioButton1.Checked = True then
begin
for i := 1 to StringGrid1.RowCount-1 do
begin
ms1[i] := StringGrid1.Cells[1,i];
ms2[i] := StringGrid1.Cells[2,i];
ms3[i] := StrToInt(StringGrid1.Cells[3,i]);
end;
for i := 1 to StringGrid1.RowCount-1 do
for j := 1 to StringGrid1.RowCount-i-1 do
begin
if ms1[j] > ms1[j+1] then
begin
s1 := ms1[j];
ms1[j] := ms1[j+1];
ms1[j+1] := s1;

s2 := ms2[j];
ms2[j] := ms2[j+1];
ms2[j+1] := s2;

s3 := IntToStr(ms3[j]);
ms3[j] := ms3[j+1];
ms3[j+1] := StrToInt(s3);

end;
end;
for i := 1 to StringGrid1.RowCount-1 do
begin
StringGrid1.Cells[1,i] := ms1[i];
StringGrid1.Cells[2,i] := ms2[i];
StringGrid1.Cells[3,i] := IntToStr(ms3[i]);
end;

end
else
if RadioButton2.Checked = True then
begin

for i := 1 to StringGrid1.RowCount-1 do
begin
ms1[i] := StringGrid1.Cells[1,i];
ms2[i] := StringGrid1.Cells[2,i];
ms3[i] := StrToInt(StringGrid1.Cells[3,i]);
end;
for i := 1 to StringGrid1.RowCount-1 do
for j := 1 to StringGrid1.RowCount-i-1 do
begin
if (ms3[j]) > (ms3[j+1]) then
begin
s1 := ms1[j];
ms1[j] := ms1[j+1];
ms1[j+1] := s1;

s2 := ms2[j];
ms2[j] := ms2[j+1];
ms2[j+1] := s2;

s3 := IntToStr(ms3[j]);
ms3[j] := ms3[j+1];
ms3[j+1] := StrToInt(s3);
end;
end;
for i := 1 to StringGrid1.RowCount-1 do
begin
StringGrid1.Cells[1,i] := ms1[i];
StringGrid1.Cells[2,i] := ms2[i];
StringGrid1.Cells[3,i] := IntToStr(ms3[i]);
end;
end
else
if RadioButton3.Checked = True then
begin
for i := 1 to StringGrid1.RowCount-1 do
begin
ms1[i] := StringGrid1.Cells[1,i];
ms2[i] := StringGrid1.Cells[2,i];
ms3[i] := StrToInt(StringGrid1.Cells[3,i]);
end;
for i := 1 to StringGrid1.RowCount-1 do
for j := 1 to StringGrid1.RowCount-i-1 do
begin
if (ms1[j] > ms1[j + 1]) or ((ms1[j] = ms1[j + 1]) and (ms3[j] > ms3[j + 1])) then
begin
s1 := ms1[j];
ms1[j] := ms1[j+1];
ms1[j+1] := s1;

s2 := ms2[j];
ms2[j] := ms2[j+1];
ms2[j+1] := s2;

s3 := IntToStr(ms3[j]);
ms3[j] := ms3[j+1];
ms3[j+1] := StrToInt(s3);

end;
end;
for i := 1 to StringGrid1.RowCount-1 do
begin
StringGrid1.Cells[1,i] := ms1[i];
StringGrid1.Cells[2,i] := ms2[i];
StringGrid1.Cells[3,i] := IntToStr(ms3[i]);
end;
end;
end;

[macomics]

for i := 1 to StringGrid1.RowCount-1 do
begin
ms1[i] := StringGrid1.Cells[1,i];
ms2[i] := StringGrid1.Cells[2,i];
ms3[i] := StrToInt(StringGrid1.Cells[3,i]);
end;
for i := 1 to StringGrid1.RowCount-1 do
for j := 1 to StringGrid1.RowCount-i-1 do
begin if ... then
begin
s1 := ms1[j];
ms1[j] := ms1[j+1];
ms1[j+1] := s1;

s2 := ms2[j];
ms2[j] := ms2[j+1];
ms2[j+1] := s2;

s3 := IntToStr(ms3[j]);
ms3[j] := ms3[j+1];
ms3[j+1] := StrToInt(s3);

end;
end;
for i := 1 to StringGrid1.RowCount-1 do
begin
StringGrid1.Cells[1,i] := ms1[i];
StringGrid1.Cells[2,i] := ms2[i];
StringGrid1.Cells[3,i] := IntToStr(ms3[i]);
end;

Зачем вы повторяете один и тот же код 3 раза?

SetLength(ms1,StringGrid1.RowCount);
SetLength(ms2,StringGrid1.RowCount);
SetLength(ms3,StringGrid1.RowCount);

А вот выделить память под массивы догадались сделать однократно

if ((RadioButton1.Checked) and (ms1[j] > ms1[j+1]))
or ((RadioButton2.Checked) and (ms3[j]) > (ms3[j+1]))
or ((RadioButton3.Checked) and ((ms1[j] > ms1[j + 1]) or ((ms1[j] = ms1[j + 1]) and (ms3[j] > ms3[j + 1]))))
then
...

Все три проверки одним условием

[mr.stranger]

Спасибо вам огромное за помощь

Обновлено 2.0

procedure TForm1.Button1Click(Sender: TObject);
 var a,b,c,f1,f2,f3,q1,q2,q3,q4:integer;
begin
q1 := 0;
q2 := 0;
q3 := 0;
q4 := 0;

for a := 1 to StringGrid1.RowCount-1 do
if StringGrid1.Cells[1,a] = Trim(Edit1.Text) then
q1 := 1;
for a := 1 to StringGrid1.RowCount-1 do
if StringGrid1.Cells[2,a] = Trim(Edit2.Text) then
q2 := 1;
for a := 1 to StringGrid1.RowCount-1 do
if StringGrid1.Cells[3,a] = Trim(Edit3.Text) then
q3 := 1;
q4 := q1 + q2 + q3;

Val(Trim(Edit1.Text),b,f1);
Val(Trim(Edit2.Text),b,f2);
Val(Trim(Edit3.Text),c,f3);

if (Length(Edit1.text) <> 0) and (Length(Edit2.text) <> 0) and (Length(Edit3.text) <> 0) and (f3 = 0) and (f1 <> 0) and (f2 <> 0) and (c > 0) then
begin
if q4 <> 3 then
begin
with StringGrid1 do
InsertRowWithValues(RowCount, [IntToStr(RowCount), Edit1.Text, Edit2.Text, Edit3.Text]);
end
else
ShowMessage('Дубль');
end
else
ShowMessage('Ошибки в записи');
end;

procedure TForm1.Button2Click(Sender: TObject);
var
 ms1,ms2:array of string;
 ms3:array of integer;
 s1,s2,s3:string;
 i,j:integer;
begin
SetLength(ms1,StringGrid1.RowCount);
SetLength(ms2,StringGrid1.RowCount);
SetLength(ms3,StringGrid1.RowCount);

for i := 1 to StringGrid1.RowCount-1 do
begin
ms1[i] := StringGrid1.Cells[1,i];
ms2[i] := StringGrid1.Cells[2,i];
ms3[i] := StrToInt(StringGrid1.Cells[3,i]);
end;
for i := 1 to StringGrid1.RowCount-1 do
for j := 1 to StringGrid1.RowCount-i-1 do
begin
if ((RadioButton1.Checked) and (ms1[j] > ms1[j+1])) or ((RadioButton2.Checked) and (ms3[j] > ms3[j+1])) or ((RadioButton3.Checked) and ((ms1[j] > ms1[j + 1]) or ((ms1[j] = ms1[j + 1]) and (ms3[j] > ms3[j + 1])))) then
begin
s1 := ms1[j];
ms1[j] := ms1[j+1];
ms1[j+1] := s1;

s2 := ms2[j];
ms2[j] := ms2[j+1];
ms2[j+1] := s2;

s3 := IntToStr(ms3[j]);
ms3[j] := ms3[j+1];
ms3[j+1] := StrToInt(s3);

end;
end;
for i := 1 to StringGrid1.RowCount-1 do
begin
StringGrid1.Cells[1,i] := ms1[i];
StringGrid1.Cells[2,i] := ms2[i];
StringGrid1.Cells[3,i] := IntToStr(ms3[i]);
end;
for i := 1 to StringGrid1.RowCount-1 do
begin
StringGrid1.Cells[1,i] := ms1[i];
StringGrid1.Cells[2,i] := ms2[i];
StringGrid1.Cells[3,i] := IntToStr(ms3[i]);
end;
end;